Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a "Collections" (or "Test Suites") feature, enabling users to group HTTP and LLM tasks, manage rich text reports with Markdown support, and generate performance comparison reports. The implementation includes new backend API endpoints, database models, and a comprehensive frontend UI. Additionally, authentication logic is updated to grant admin privileges by default when LDAP is disabled. Feedback suggests filtering out soft-deleted tasks when listing collection items and recommends using finite timeouts instead of disabling them entirely in the task testing services to prevent potential resource exhaustion.
| http_result = await db.execute( | ||
| select(HttpTask).where(HttpTask.id.in_(http_task_ids)) | ||
| ) |
There was a problem hiding this comment.
The query should filter out soft-deleted tasks to ensure they don't appear in the collection's task list.
| llm_result = await db.execute( | ||
| select(LlmTask).where(LlmTask.id.in_(llm_task_ids)) | ||
| ) |
There was a problem hiding this comment.
The query should filter out soft-deleted tasks to ensure they don't appear in the collection's task list.
| # No timeout for testing API endpoints | ||
| timeout_config = None |
There was a problem hiding this comment.
Disabling timeouts entirely (None) for API testing is risky as it can lead to hanging backend tasks if the target URL is unresponsive. It is safer to use a generous but finite timeout (e.g., 60 or 120 seconds).
| # No timeout for testing API endpoints as some LLM models may take a long time | ||
| timeout_config = None |
There was a problem hiding this comment.
Disabling timeouts entirely (None) for LLM API testing is risky. While some models take time to respond, an infinite timeout can exhaust server resources if a request hangs. Consider using a high but finite timeout (e.g., 300 seconds).
Made-with: Cursor
Made-with: Cursor
… detail Made-with: Cursor
1 participant
No description provided.